Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(docs-infra): refactors createOverviewDump #37141

Closed

Conversation

sonukapoor
Copy link
Contributor

This commit removes the dependency on the lodash module and refactors
the createOverviewDump method.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

This commit removes the dependency on the `lodash` module and refactors
the `createOverviewDump` method.
Copy link
Member

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@petebacondarwin petebacondarwin added comp: docs-infra action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels May 16, 2020
@ngbot ngbot bot added this to the needsTriage milestone May 16, 2020
kara pushed a commit that referenced this pull request May 18, 2020
This commit removes the dependency on the `lodash` module and refactors
the `createOverviewDump` method.

PR Close #37141
@kara kara closed this in 22d80a6 May 18, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 18, 2020
profanis pushed a commit to profanis/angular that referenced this pull request Sep 5, 2020
This commit removes the dependency on the `lodash` module and refactors
the `createOverviewDump` method.

PR Close angular#37141
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants